Skip to content

Commit

Permalink
ARTEMIS-4589: consolidate utility code and remove the remaining test-…
Browse files Browse the repository at this point in the history
…jar creations in tests/ tree
  • Loading branch information
gemmellr authored and clebertsuconic committed Jan 30, 2024
1 parent 14bbc04 commit 8ad8c9d
Show file tree
Hide file tree
Showing 70 changed files with 200 additions and 351 deletions.
6 changes: 0 additions & 6 deletions artemis-cli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,6 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.activemq</groupId>
<artifactId>artemis-junit</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>

<!-- The johnzon-core and json-api contents are repackaged in -commons,
However maven can still need them during tests, which run against
Expand Down
26 changes: 21 additions & 5 deletions tests/artemis-test-support/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@
<artifactId>proton-j</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-buffer</artifactId>
Expand Down Expand Up @@ -115,6 +110,11 @@
<artifactId>jakarta.jms-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>jakarta.resource</groupId>
<artifactId>jakarta.resource-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand All @@ -126,12 +126,28 @@
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.activemq</groupId>
<artifactId>artemis-jms-server</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.activemq</groupId>
<artifactId>artemis-stomp-protocol</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j2-impl</artifactId>
<scope>provided</scope>
</dependency>

<!-- This should be the only dependency not at 'provided' scope -->
<dependency>
Expand Down

Large diffs are not rendered by default.

Loading

0 comments on commit 8ad8c9d

Please sign in to comment.