Skip to content

Commit

Permalink
NO-JIRA fix flaky test QueueControlTest#testResetMessagesAdded
Browse files Browse the repository at this point in the history
The occasional assertion error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.

I did not observe the timing issue on all asserts (only on the first
two), but there is no harm in replacing them all.

    java.lang.AssertionError:
    Expected :2
    Actual   :1

(cherry picked from commit 23a30b6)
  • Loading branch information
jiridanek authored and clebertsuconic committed Aug 8, 2018
1 parent 2fdcc9f commit b08bff0
Showing 1 changed file with 4 additions and 4 deletions.
Expand Up @@ -2311,17 +2311,17 @@ public void testResetMessagesAdded() throws Exception {

ClientProducer producer = session.createProducer(address);
producer.send(session.createMessage(durable));
Assert.assertEquals(1, getMessagesAdded(queueControl));
Wait.assertEquals(1, () -> getMessagesAdded(queueControl));
producer.send(session.createMessage(durable));
Assert.assertEquals(2, getMessagesAdded(queueControl));
Wait.assertEquals(2, () -> getMessagesAdded(queueControl));

consumeMessages(2, session, queue);

Assert.assertEquals(2, getMessagesAdded(queueControl));
Wait.assertEquals(2, () -> getMessagesAdded(queueControl));

queueControl.resetMessagesAdded();

Assert.assertEquals(0, getMessagesAdded(queueControl));
Wait.assertEquals(0, () -> getMessagesAdded(queueControl));

session.deleteQueue(queue);
}
Expand Down

0 comments on commit b08bff0

Please sign in to comment.