ARTEMIS-3947 fix merging for expiry address-settings

apache · Aug 20, 2022 · f1c9e3d · f1c9e3d
1 parent 86db53d
commit f1c9e3d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/...-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java b/...-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java
@@ -175,11 +175,11 @@ public class AddressSettings implements Mergeable<AddressSettings>, Serializable
 
    private SimpleString expiryAddress = null;
 
-   private Long expiryDelay = AddressSettings.DEFAULT_EXPIRY_DELAY;
+   private Long expiryDelay = null;
 
-   private Long minExpiryDelay = AddressSettings.DEFAULT_MIN_EXPIRY_DELAY;
+   private Long minExpiryDelay = null;
 
-   private Long maxExpiryDelay = AddressSettings.DEFAULT_MAX_EXPIRY_DELAY;
+   private Long maxExpiryDelay = null;
 
    private Boolean defaultLastValueQueue = null;
 
@@ -769,7 +769,7 @@ public AddressSettings setExpiryQueueSuffix(final SimpleString value) {
    }
 
    public Long getExpiryDelay() {
-      return expiryDelay;
+      return expiryDelay != null ? expiryDelay : AddressSettings.DEFAULT_EXPIRY_DELAY;
    }
 
    public AddressSettings setExpiryDelay(final Long expiryDelay) {
@@ -778,7 +778,7 @@ public AddressSettings setExpiryDelay(final Long expiryDelay) {
    }
 
    public Long getMinExpiryDelay() {
-      return minExpiryDelay;
+      return minExpiryDelay != null ? minExpiryDelay : AddressSettings.DEFAULT_MIN_EXPIRY_DELAY;
    }
 
    public AddressSettings setMinExpiryDelay(final Long minExpiryDelay) {
@@ -787,7 +787,7 @@ public AddressSettings setMinExpiryDelay(final Long minExpiryDelay) {
    }
 
    public Long getMaxExpiryDelay() {
-      return maxExpiryDelay;
+      return maxExpiryDelay != null ? maxExpiryDelay : AddressSettings.DEFAULT_MAX_EXPIRY_DELAY;
    }
 
    public AddressSettings setMaxExpiryDelay(final Long maxExpiryDelay) {

diff --git a/...s-server/src/test/java/org/apache/activemq/artemis/core/settings/AddressSettingsTest.java b/...s-server/src/test/java/org/apache/activemq/artemis/core/settings/AddressSettingsTest.java
@@ -71,6 +71,9 @@ public void testSingleMerge() {
       addressSettingsToMerge.setPageSizeBytes(1004);
       addressSettingsToMerge.setMaxSizeBytesRejectThreshold(10 * 1024);
       addressSettingsToMerge.setConfigDeleteDiverts(DeletionPolicy.FORCE);
+      addressSettingsToMerge.setExpiryDelay(999L);
+      addressSettingsToMerge.setMinExpiryDelay(888L);
+      addressSettingsToMerge.setMaxExpiryDelay(777L);
 
       addressSettings.merge(addressSettingsToMerge);
       Assert.assertEquals(addressSettings.getDeadLetterAddress(), DLQ);
@@ -84,6 +87,9 @@ public void testSingleMerge() {
       Assert.assertEquals(AddressFullMessagePolicy.DROP, addressSettings.getAddressFullMessagePolicy());
       Assert.assertEquals(addressSettings.getMaxSizeBytesRejectThreshold(), 10 * 1024);
       Assert.assertEquals(DeletionPolicy.FORCE, addressSettings.getConfigDeleteDiverts());
+      Assert.assertEquals(Long.valueOf(999), addressSettings.getExpiryDelay());
+      Assert.assertEquals(Long.valueOf(888), addressSettings.getMinExpiryDelay());
+      Assert.assertEquals(Long.valueOf(777), addressSettings.getMaxExpiryDelay());
    }
 
    @Test