ARTEMIS-1098 Improve flow control while streaming large messages #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
force-pushed
the
streaming_large_msg
branch
from
ee9d8db
to
c6d24e9
Compare
| final long endFlowControl = System.nanoTime(); | ||
| final long elapsedFlowControl = endFlowControl - startFlowControl; | ||
| final long elapsedMillis = TimeUnit.NANOSECONDS.toMillis(elapsedFlowControl); | ||
| logger.warn("try to write " + expectedEncodeSize + " bytes after blocked " + elapsedMillis + " ms on a not writable connection: [" + connection.getID() + "]"); |
There was a problem hiding this comment.
last thing Missing... define method through Logger please?
There was a problem hiding this comment.
@franz1981 instead of asking you to make a change, I am amending a small change on logger here with your PR.
Beware if you pickup this change towards 1.x as I know you will do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.