ARTEMIS-1180: Artemis is logging warnings during server shut down #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -719,7 +719,7 @@ void slowConsumerDetected(String sessionID, | |||
| @Message(id = 222094, value = "Bridge unable to send message {0}, will try again once bridge reconnects", format = Message.Format.MESSAGE_FORMAT) | |||
| void bridgeUnableToSendMessage(@Cause Exception e, MessageReference ref); | |||
|
|
|||
| @LogMessage(level = Logger.Level.WARN) | |||
| @LogMessage(level = Logger.Level.INFO) | |||
There was a problem hiding this comment.
What is the difference? just the [WARN] on the logs?
Why is that an issue?
Shouldn't the proper fix be.. if it's shutting down.. log.debug, if !... log.warn?
or this is about client nodes?
There was a problem hiding this comment.
We had a talk on IRC about this:
dtikhomi: customer is parsing logs, and in that case warn is false alarm for him
[09:42am] clebert: but the thing is...
[09:42am] clebert: when that issue is actually happening for a bad cause
[09:42am] clebert: he won’t be alarmed for the real issue
[09:42am] clebert: so .. that’s my concern
[09:42am] clebert: nodes stop because of network outages...
[09:43am] clebert: he won’t get notice
[09:43am] dtikhomi: ohhh, i got it
[09:43am] clebert: or missing connectiong because of outages
[09:43am] clebert: u agree with me?
[09:43am] dtikhomi: plz dont close PR i will update it
[09:43am] dtikhomi: yeap, you right
[09:44am] clebert: but do you think you know how to fix it with an easy fix?
[09:44am] clebert: I thought it would be more substantial for a proper fix
[09:44am] clebert: (like… is Shutting Down somewhere… ignore it)
[09:44am] clebert: that’s actually the fix
[09:44am] clebert: server.isStopping
[09:44am] clebert: —> don’t log it
[09:44am] clebert: or log.debug
[09:44am] dtikhomi: yeap, i wonna try
[09:45am] clebert: ok.. thanks a lot...
treblereel
force-pushed
the
APACHE_JBEAP-6180
branch
from
c8322f9
to
38dafb7
Compare
| @@ -606,7 +610,8 @@ public void connectionFailed(final ActiveMQException me, boolean failedOver) { | |||
|
|
|||
| @Override | |||
| public void connectionFailed(final ActiveMQException me, boolean failedOver, String scaleDownTargetNodeID) { | |||
| ActiveMQServerLogger.LOGGER.bridgeConnectionFailed(failedOver); | |||
| if(server.isStarted()) | |||
| ActiveMQServerLogger.LOGGER.bridgeConnectionFailed(failedOver); | |||
There was a problem hiding this comment.
seems out of alignment to me.. this would fail checkstyle apparently.
treblereel
force-pushed
the
APACHE_JBEAP-6180
branch
from
38dafb7
to
13939ee
Compare
treblereel
force-pushed
the
APACHE_JBEAP-6180
branch
from
13939ee
to
dbbe4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1180