ARTEMIS-1194: SOCKS proxy support

[adagys]

This work enables Artemis connectors to use a SOCKS proxy, by adding an appropriate netty socks handler to the channel pipeline. The proxy is only enabled for a public remote host.

I tested that it works correctly.

If this is acceptable functionality to be included in Artemis I'm happy to do some more polishing to get it in the right shape.

[clebertsuconic]

nice feature!!!

= it needs a test.. (especially one that uses the URI for the connector)

and... how to test this.. any proxy support in Java we can deploy?

[jbertram]

Also needs a JIRA and there are a handful of checkstyle violations.

[clebertsuconic]

proxyEnabled is a more intuite name...

especially if you specify a connector with ?useSocket=true;proxyHost=;proxyPort;proxyUser;proxyPassword...

so.. better property names:

• proxyEnabled
• proxyUser
• proxyPassword
• proxyPort
• proxyHost

[jbertram]

Please open a JIRA for this, squash all of your commits, and amend your commit message to follow what's outlined in the Hacking Guide.

[adagys]

Will do 👍

[clebertsuconic]

you could squash all your committs into a single one here:

git rebase -i HEAD~2

squash them, change the tittle

git push origi -f

[adagys]

this is ready for another look @clebertsuconic

[clebertsuconic]

I was trying to make a test like this:

clebertsuconic@2f7cbc9

but I'm not sure I will have to time to finish it... if you want to take over this test?

[adagys]

can do, so the point of this test is just to check that NettyConnector can establish a connection when the proxy handler is enabled, right?

[clebertsuconic]

Yes, basically I wanted to start a proxy, and make sure it worked through the proxy.
I was looking to assert the proxy was used.. but I didn't have time to finish the test...

[adagys]

I tried it with the MockServer proxy but it seems to only work with http traffic.. Maybe it's sufficient to just open a socket at the socks port and make sure a connection gets established? Handling the SOCKS protocol is technically the responsibility of Netty.

[clebertsuconic]

@adagys we still need a way to test it though.. I looked at their website and it seems to support SOCKS.. but I didn't figure out how.

I think we should remove the option you added to ignore localhost though. If it's proxy, always proxy...

[mtaylor]

@clebertsuconic @adagys This has been open since May. What needs to happen before we can merge/close?

[clebertsuconic]

Test

[adagys]

I couldn't get it to work in the end and don't have time to work on it anymore.., can be closed

[clebertsuconic]

@adagys did you at least try the feature alone? was it working? I couldn't get it to work.

I was interested on the feature.. but I couldn't get the test to work.

[adagys]

Yep, I remember seeing it work in an end-to-end scenario, but couldn't get the test to work either.. Which is strange

[clebertsuconic]

Can you do one last rebase 👍
(git pull --rebase upstream master)
... resolve conflicts
git push origin -f

and I will work on the tests soon. (kind of last week)

[adagys]

Rebased 👍

[michaelandrepearce]

@clebertsuconic whats occuring on this, we ok to merge? And simply mark feature beta until some decent tests?

[michaelandrepearce]

@clebertsuconic I'm merging this.

[michaelandrepearce]

just needs sorting dependencies, seems the project removed netty all here, so just having to add

     <dependency>
        <groupId>io.netty</groupId>
        <artifactId>netty-handler-proxy</artifactId>
        <version>${netty.version}</version>
        <!-- License: Apache 2.0 -->
     </dependency>
     <dependency>
        <groupId>io.netty</groupId>
        <artifactId>netty-codec-socks</artifactId>
        <version>${netty.version}</version>
        <!-- License: Apache 2.0 -->
     </dependency>

[jbertram]

@michaelandrepearce, org.apache.activemq.artemis.tests.unit.core.remoting.impl.netty.NettyConnectorTest#testSocksProxyHandlerAdded is failing consistently. This may need to be reverted.

[jbertram]

@michaelandrepearce, I think I've got a fix for this. Will send a PR shortly...

[jbertram]

Just sent #3010.

[celiovasconcelos]

Map<String, Object> params = new HashMap<>();
params.put(TransportConstants.HOST_PROP_NAME, "localhost");
params.put(TransportConstants.PORT_PROP_NAME, "61617"); //<acceptor name="netty">tcp://0.0.0.0:61617</acceptor>
params.put(TransportConstants.PROXY_ENABLED_PROP_NAME, "true");
params.put(TransportConstants.PROXY_HOST_PROP_NAME, "localhost");
params.put(TransportConstants.PROXY_PORT_PROP_NAME, "1080");
params.put(TransportConstants.PROXY_USERNAME_PROP_NAME, "user");
params.put(TransportConstants.PROXY_PASSWORD_PROP_NAME, "WRONG_PASSWORD");

TransportConfiguration transportConfiguration = new TransportConfiguration("org.apache.activemq.artemis.core.remoting.impl.netty.NettyConnectorFactory", params);
ActiveMQConnectionFactory activeMQConnectionFactory = ActiveMQJMSClient.createConnectionFactoryWithoutHA(JMSFactoryType.CF, transportConfiguration);

<dependency>
  <groupId>org.apache.activemq</groupId>
  <artifactId>artemis-jms-client</artifactId>
  <version>2.14.0</version>
</dependency>

This is ignoring the proxy conf.

Am I doing something wrong?

[jbertram]

@celiovasconcelos, this is an old, closed pull request. It's not really meant for support. Try using the ActiveMQ User Mailing List.

[celiovasconcelos]

Sorry.
I've posted it in https://stackoverflow.com/questions/63248592/amq-artemis-socks-proxy-support
Thank you.