Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-1291 - fix incorrect links in the documentation #1473

Closed
wants to merge 1 commit into from

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Aug 19, 2017

Some links in the documentation point to non-existent pages within the Apache website. The links make reference to classes and code in the documentation. This patch updates them to point to the source code in Github.

@orpiske
Copy link
Contributor Author

orpiske commented Aug 19, 2017

For verifying this fixes, I generated the documentation. For further review, the corrected pages can be reviewed in these two links:

Additionally, the updated links also work when browsing the documentation via Github.

@@ -22,20 +22,20 @@ The broker is comprised of POJOs so it's simple to configure and run a broker in
Even complex test-cases involving multiple clustered brokers are relatively easy to write. Almost every test in the
test-suite follows this pattern - configure broker, start broker, test functionality, stop broker.

The test-suite uses JUnit to manage test execution and life-cycle. Most tests extend [`org.apache.activemq.artemis.tests.util.ActiveMQTestBase`](../../../artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java)
The test-suite uses JUnit to manage test execution and life-cycle. Most tests extend [`org.apache.activemq.artemis.tests.util.ActiveMQTestBase`](https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intention here was to have the docs at http://activemq.apache.org/artemis/artemis-server/src/test/java/org/apache/activemq/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SingleServerSimpleTest.java showing the right git link...

for some reason it's not working...

but you can't use the one you're using to fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clebertsuconic thanks, understood.

My initial thought was to point them to the API documentation already present on the website, but some of the code mentioned on the documentation does not appear there.

Do you have any suggestion about where to point these links or how to handle it? I can adjust these links to point to the correct location or I can try to generate the docs for the missing classes ...

@asfgit asfgit closed this in 0e4ae20 Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants