Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-1446 - Support Transformer configuration by properties #1569

Closed

Conversation

michaelandrepearce
Copy link
Contributor

Update Tranformer to be able to handle initiation via propertiers (map<string, string>)
Update Configuration to have more specific transfromer configuration type, and to take properties.
Support back compatibility.
Add AddHeadersTransformer which is a main use case, and can act as example also.
Update Control's to expose new property configuration
Add test cases
Update examples for new transformer config style

@michaelandrepearce
Copy link
Contributor Author

Background small discussion on dev mail list http://activemq-dev.markmail.org/message/sunyg6rohsplus7e?q=properties+bridge suggesting to use properties (ala map<string,string>)

@jbertram
Copy link
Contributor

jbertram commented Oct 5, 2017

This looks good, but I'm a bit concerned about using a Map in the management methods as this will preclude the use of tools like JVisualVM, JConsole, Jolokia, etc. to invoke those methods as they have no way to represent a Map in plain text. Perhaps consider using a comma delimited String of key=value pairs instead of Map for the management methods.

@michaelandrepearce
Copy link
Contributor Author

michaelandrepearce commented Oct 5, 2017

@jbertram good point, i think the standard looking at other controls is to output JSON string form as well as map. Have updated so it returns/takes also a map as a JSON representation string.

@michaelandrepearce michaelandrepearce force-pushed the ARTEMIS-1446 branch 5 times, most recently from a1a301f to 6e0d3a7 Compare October 5, 2017 17:32
Update Tranformer to be able to handle initiation via propertiers (map<string, string>)
Update Configuration to have more specific transfromer configuration type, and to take properties.
Support back compatibility.
Add AddHeadersTransformer which is a main use case, and can act as example also.
Update Control's to expose new property configuration
Add test cases
Update examples for new transformer config style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants