ARTEMIS-1532 Enable tests which are unintentionally skipped by Surefire #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirkadanek
force-pushed
the
jd_skipped_tests
branch
4 times, most recently
from
535efb7
to
f6daa92
Compare
|
Are you sure it was unintentional ? I’m not on a computer now. But I remember a few tests that were commented out instead of removed to be checked later and we never got back to them. |
jirkadanek
force-pushed
the
jd_skipped_tests
branch
from
f6daa92
to
53c5e20
Compare
These tests used to have a wrong name, so they weren't executed by Surefire during a `mvn test` run. After enablement, the following tests are now failing: * org.apache.activemq.artemis.tests.integration.cluster.ha.HAAutomaticBackupSharedStoreTest * org.apache.activemq.artemis.tests.integration.ra.OutgoingConnectionNoJTATest * org.apache.activemq.artemis.tests.unit.core.server.group.impl.SystemPropertyOverrideTest.testSystemPropertyOverride
jirkadanek
force-pushed
the
jd_skipped_tests
branch
from
53c5e20
to
5d6b614
Compare
|
Well, I might've guessed the intent wrong in one or two cases, I guess. If I thought it is unintentional, I've either renamed the class (so that Surefire would pick it) or added the @test annotation. (First commit) If I thought it is intentional, I've added @ignored annotation instead of whichever other method was used to disable that test. (Third commit) |
|
@mtaylor @clebertsuconic could we fix this up, seems this got merged with PR build broken, and since PR is constantly failing with this test testSystemPropertyOverride |
Merged
|
Have sent in #1737 to fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready to be merged, because
HAAutomaticBackupSharedStoreTestandtestSystemPropertyOverrideare failing after these changes.