ARTEMIS-1613 Integrating JDBC into CLI (create print-data and exp) #1781
Conversation
clebertsuconic
force-pushed
the
jdbc
branch
3 times, most recently
from
17a1877
to
392f965
Compare
|
I think it's worth clarifying the specific purpose of Derby in the documentation. My understanding here is that Derby is being packaged for demonstration purposes only and shouldn't be used as a production JDBC implementation. |
clebertsuconic
force-pushed
the
jdbc
branch
3 times, most recently
from
d14aa5b
to
bf0c5fe
Compare
| <!-- The most efficient persistent layer for Artemis is the file-store, | ||
| however if you require a database please refer to your database provider | ||
| for any database specific questions. | ||
| We don't endorse any specific JDBC provider. Derby is provided by default for demonstration purposes. --> |
There was a problem hiding this comment.
Change this comment since we won't package Derby?
| // Default JDBC Driver class name | ||
| private static String DEFAULT_JDBC_DRIVER_CLASS_NAME = null; | ||
| // Default JDBC Driver class name, derby by default just for demo purposes | ||
| private static String DEFAULT_JDBC_DRIVER_CLASS_NAME = "org.apache.derby.jdbc.EmbeddedDriver"; |
There was a problem hiding this comment.
Should this be null since we won't be packaging Derby?
| @@ -557,6 +592,25 @@ public Object run(ActionContext context) throws Exception { | |||
| filters.put("${global-max-section}", readTextFile(ETC_GLOBAL_MAX_SPECIFIED_TXT, filters)); | |||
| } | |||
|
|
|||
| if (jdbc) { | |||
| if (jdbcURL == null) { | |||
| jdbcURL = "jdbc:derby:" + getInstance().getAbsolutePath() + "/data/derby/db;create=true"; | |||
There was a problem hiding this comment.
Should this be left null as well rather than defaulting to Derby?
There was a problem hiding this comment.
Nope.. .lets not complicate things even further? :)
The config will be defaulted to Derby if no parameters.. then the user can install derby. it's a nice experience out of box. easy to install. easy to run.
There was a problem hiding this comment.
@jbertram I want to keep this as is.. with some default to be used.
No description provided.