ARTEMIS-1619 - Add plugin support for address lifecyle #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| } catch (Throwable e) { | ||
| e.printStackTrace(); | ||
| fail(e.getMessage()); |
There was a problem hiding this comment.
the printStackTrace is useful when it fails :)
I have been there.
There was a problem hiding this comment.
this is actually the only request I'm going to make.. almost merged this.
There was a problem hiding this comment.
hmmmm.. but it was being ignored before?
maybe just remove the catch and let it fail? remove the throws Exception on the test?
There was a problem hiding this comment.
yeah i can remove it, i'm not sure why it's there at all
There was a problem hiding this comment.
ok i updated the PR
Adding callbacks to the plugin API for address creation, update and removals
cshannon
force-pushed
the
ARTEMIS-1619
branch
from
07b8e79
to
fbb75bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding callbacks to the plugin API for address creation, update and
removals