ARTEMIS-1647 - Add plugin support for binding creation and removal #1829
Conversation
| @@ -571,6 +571,8 @@ public AddressInfo getAddressInfo(SimpleString addressName) { | |||
| // even though failover is complete | |||
| @Override | |||
| public synchronized void addBinding(final Binding binding) throws Exception { | |||
| server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.beforeAddBinding(binding) : null); | |||
There was a problem hiding this comment.
Due to the default uses on callBrokerPlugins and other wierd reasons dependent by how the JIT works with compilations/inlining/interface optimization would be better at least to turn it into:
if(server.hasBrokerPlugins()){
....
}
I've noticed it is used on most "cold path" of the broker so it is fine to left as it is in this place too: it doesn't seem a hot path. My suggestion is just for wider puporses 👍
There was a problem hiding this comment.
I can change it everywhere the plugins are called. There are some hot paths where the plugins are called such as during message routing so if that change will improve performance then that is fine.
Adds callbacks to ActiveMQServerPlugin for binding add and remove events
cshannon
force-pushed
the
ARTEMIS-1647
branch
from
c273ce4
to
51cb5df
Compare
|
@franz1981 - I updated the PR, is this ok to merge now? |
|
@cshannon Perfect, thanks!!!! 👍 |
|
@franz1981 - can you do the PR merge? |
Adds callbacks to ActiveMQServerPlugin for binding add and remove events