Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-853 Support for exclusive consumers #1856

Closed

Conversation

michaelandrepearce
Copy link
Contributor

Alternative QueueImpl - Seperated logic without counters

Alternative QueueImpl - Seperated logic without counters
@michaelandrepearce
Copy link
Contributor Author

michaelandrepearce commented Feb 7, 2018

@clebertsuconic as per your comment to look at an alternative QueueImpl with it having separate flow without counters for exclusive.

IMO i don't think this is a better approach, but i want to offer it to you.

There is an amount of logic that is almost similar but not re-usable or abstract-able due to the pos and counters being inter-twined (ive done what i could).

This is why i followed the same logic that MessageGroups does when a group already is assigned,
which is to override the consumer and then don't update the pos, as it made for a lot smaller change, less intrusive change following a pattern already done with msg groups.

Anyhow if you prefer this then im not dead opposed to this approach just don't think its better, but i offer it for your review.

@clebertsuconic
Copy link
Contributor

I will need to look on this on Monday. Will be traveling for a few days.

@michaelandrepearce
Copy link
Contributor Author

I’m closing this as no further comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants