Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-1661 Support splitting of broker.xml #1896

Merged
merged 1 commit into from Feb 27, 2018

Conversation

michaelandrepearce
Copy link
Contributor

@michaelandrepearce michaelandrepearce commented Feb 26, 2018

Support XML standard XInclude thus allowing splitting of the broker.xml
Added test cases with split out config using include.

@michaelandrepearce
Copy link
Contributor Author

just rebased.

@gaohoward
Copy link
Contributor

@michaelandrepearce do you think we should add some documentation for this feature?

@adirubin
Copy link

Hi michaelandrepearce, thanks!
If I'm not mistaken, the server won't monitor the x-included files for changes, which could be a problem.

Support XML standard XInclude thus allowing splitting of the broker.xml
Added test cases with split out config using include.
@michaelandrepearce
Copy link
Contributor Author

michaelandrepearce commented Feb 27, 2018

@adirubin thats correct, you'll need to "touch" the broker.xml file to make the broker reload, this is very similar to the support for config modularity used in other projects such as log4j e.g. there also you need to "touch" the parent log4j.xml still to make log4j reload it.

It would be possible to make the file watcher watch x-included files also, but i want to introduce the basics first which is the simple support of breakout of files, via XML standards

@michaelandrepearce
Copy link
Contributor Author

@gaohoward Updated docs 👍

@gaohoward
Copy link
Contributor

@adirubin good point. I'm going to merge this and improve it in a separate commit.

@asfgit asfgit merged commit 9d1c59c into apache:master Feb 27, 2018
asfgit pushed a commit that referenced this pull request Feb 27, 2018
@michaelandrepearce
Copy link
Contributor Author

@gaohoward you on IRC? want to sync up / chat to avoid duplicating effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants