ARTEMIS-1737 Fixing WebServer stopped #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
force-pushed
the
ARTEMIS-1737
branch
from
6a0f323
to
91c0452
Compare
michaelandrepearce
requested changes
Mar 9, 2018
There was a problem hiding this comment.
@clebertsuconic I think you missed what I was flagging up about network pinger.(and possibly other bits), The original change done way back has caused that to be stopped in this case as well. Just the console was the most visible undesirable change when isExit changes from false to true .
|
@michaelandrepearce when isExit=true, it means the VM is going away. The previous task was to shutdown the server upon a forceCall, on that case isExit must be true. I changed it to the previous method and I am using @stanlyDoge's test to validate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacing #1940
#1940 will be closed when this one is merged.