ARTEMIS-1779 ClusterConnectionBridge may connect to other nodes than its target #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its target The cluster connection bridge has a TopologyListener and connects to a new node each time it receives a nodeUp() event. It needs to put a check here to make sure that the cluster bridge only connects to its target node and it's backups. This issue shows up when you run LiveToLiveFailoverTest.testConsumerTransacted test. Also in this commit improvement of BackupSyncJournalTest so that it runs more stable.
| @@ -127,9 +126,6 @@ public ClusterConnectionBridge(final ClusterConnection clusterConnection, | |||
| this.managementNotificationAddress = managementNotificationAddress; | |||
| this.flowRecord = flowRecord; | |||
|
|
|||
| // we need to disable DLQ check on the clustered bridges | |||
| queue.setInternalQueue(true); | |||
There was a problem hiding this comment.
Why did you change this?
It seems it doesn't have any connection to your change.
Beyond that.. we don't want any DLQ processing on internal queues from clustered bridge. This is a dangerous change.
There was a problem hiding this comment.
@clebertsuconic no it doesn't. But it's redundant because this has already been set during the creation of cluster connection bridge. See
org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionImpl#nodeUP()
There was a problem hiding this comment.
Ok.. I see..
I have a small refactoring on this.. instead of trusting queue.isInternal I think we should move nodeUp to Bridge, and @OverRide on the ClusterBridge.
I'm running some tests before I merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster connection bridge has a TopologyListener and connects to a new node
each time it receives a nodeUp() event. It needs to put a check here to make
sure that the cluster bridge only connects to its target node and it's backups.
This issue shows up when you run LiveToLiveFailoverTest.testConsumerTransacted
test.
Also in this commit improvement of BackupSyncJournalTest so that it runs more
stable.