[ARTEMIS-1770] Log warning instead of stacktrace while shutdown #1990
Conversation
|
While clear shutdown it makes no sence to throw any exception. It should be sufficient just to log message about whats happening. |
| import org.apache.activemq.artemis.api.core.ActiveMQExceptionType; | ||
| import org.apache.activemq.artemis.api.core.Message; | ||
| import org.apache.activemq.artemis.api.core.SimpleString; | ||
| import org.apache.activemq.artemis.api.core.*; |
There was a problem hiding this comment.
Star imports like this are not allowed by our checkstyle config. You'll need to change this for the PR build to pass.
rstancel
force-pushed
the
ARTEMIS-1770
branch
3 times, most recently
from
515002f
to
688d63b
Compare
|
Can someone please run retest? I have the same issue on Travis as this PR: #1985 and I think it has nothing to do with my PR |
| @@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags) throws XAException { | |||
| startCall(); | |||
| try { | |||
| sessionContext.xaEnd(xid, flags); | |||
| } catch (ActiveMQNotConnectedException ex) { | |||
| ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage()); | |||
There was a problem hiding this comment.
can you at least keep a logger.debug(ex.getMessage(), ex) here?
This way if a developer ever needs to debug on why.. it would give the developer more information?
There was a problem hiding this comment.
and as I requested you this small change.. can you rebase against master? that would help me to find that pesky AIO failure on travis.
There was a problem hiding this comment.
@clebertsuconic Done.
Jira: https://issues.apache.org/jira/browse/ARTEMIS-1770