ARTEMIS-1930 + some debug logging #2148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-1930
branch
2 times, most recently
from
231a671
to
43a95be
Compare
| @@ -582,6 +582,27 @@ public void handleFrame(StompFrame request) { | |||
| } | |||
| } | |||
|
|
|||
| public void logFrame(StompFrame request, boolean in) { | |||
| if (ActiveMQStompProtocolLogger.LOGGER.isDebugEnabled()) { | |||
There was a problem hiding this comment.
for direct calls on debug and trace, I would use an individualized Logger.
Logger logger = Logger.getLogger(StompConnection.class)
we should use Logger only for INFO messages with ID... as of debugging this, it gets fairly difficult to do it without the individual logs. Just wait till you ask debug loggers from users and it gets fairly difficult.
There was a problem hiding this comment.
Understood. I'll change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.