ARTEMIS-1966 Replication channel closed but not connection if flow co… #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrolled during replication
wy96f
force-pushed
the
stop_connection_if_flowcontrolled
branch
from
0781b1d
to
5ad9e2f
Compare
|
Thanks... I'm also adding a commit to improve the test you added. Take a look please for future references. (I decided to just change it instead of asking the change here). thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use SharedNothing Activation. If flow control occurs during replication, replication channel would be closed and enabled flag is set to false. After it, the message would not be sent to backup node. If live server crashes at this time, the backup node will fail over, resulting in data loss.
So we close connection if flow controlled, then backup node would be signaled failure replicating and restart server.