Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTEMIS-1971 - close ldap context on clear and add support for connec… #2173

Closed
wants to merge 1 commit into from
Closed

ARTEMIS-1971 - close ldap context on clear and add support for connec… #2173

wants to merge 1 commit into from

Conversation

gtully
Copy link
Contributor

@gtully gtully commented Jul 6, 2018

…tion pooling

@asfgit asfgit closed this in ae29edf Jul 6, 2018
@jbertram
Copy link
Contributor

jbertram commented Jul 6, 2018

Just for the record, when I merged this I split this into 2 commits - one for the bug (ARTEMIS-1970) and one for the feature (ARTEMIS-1971).

@michaelandrepearce
Copy link
Contributor

@jbertram , @gtully It seems since this is merged there is an issue in building master. LDAPLoginModuleTest.testLoginPooled fails consistently

@michaelandrepearce michaelandrepearce mentioned this pull request Jul 10, 2018
Closed
@jbertram
Copy link
Contributor

@michaelandrepearce, @gtully, I'm hoping that #2183 resolves the spurious test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gtully @jbertram @michaelandrepearce