Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-856 - Support consumersBeforeDispatch and delayBeforeDispatch #2198

Merged
merged 1 commit into from Jul 31, 2018

Conversation

michaelandrepearce
Copy link
Contributor

https://issues.apache.org/jira/browse/ARTEMIS-856

This is equivalent to consumersBeforeDispatchStarts and timeBeforeDispatchStarts in ActiveMQ 5.x

http://activemq.apache.org/message-groups.html

This is addressing one of the items on the artemis roadmap: http://activemq.apache.org/activemq-artemis-roadmap.html

@michaelandrepearce
Copy link
Contributor Author

michaelandrepearce commented Jul 30, 2018

@clebertsuconic wouldn't let me re-open so heres new PR of the same branch rebased on master. Seems master has a new issue thats affecting other PR's also.

@michaelandrepearce
Copy link
Contributor Author

i think its the same issue @cshannon is getting on his PR also. #2191

https://issues.apache.org/jira/browse/ARTEMIS-856

This is equivalent to consumersBeforeDispatchStarts and timeBeforeDispatchStarts in ActiveMQ 5.x

http://activemq.apache.org/message-groups.html

This is addressing one of the items on the artemis roadmap: http://activemq.apache.org/activemq-artemis-roadmap.html
@michaelandrepearce
Copy link
Contributor Author

@clebertsuconic re-pushed to kick off build again and all green. You ok to merge?

@clebertsuconic
Copy link
Contributor

clebertsuconic commented Jul 31, 2018

@michaelandrepearce What did you do to fix the karaf verification? i lost some sleep the other day trying to figure it out and I'm now curious.

@michaelandrepearce
Copy link
Contributor Author

michaelandrepearce commented Jul 31, 2018

@clebertsuconic i removed the custom AtomicBooleanFieldUpdater as @franz1981 wanted and just used AtomicIntegerFieldUpdater direct. Seems i fix the issue and make @franz1981 happy at the same time :)

@clebertsuconic
Copy link
Contributor

@michaelandrepearce Ok.. there's an issue with packaging in Karaf for Util depending on how you use. I'm sure it will arise again.

@asfgit asfgit merged commit 8a9835a into apache:master Jul 31, 2018
asfgit pushed a commit that referenced this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants