ARTEMIS-856 Test fixes #2209
ARTEMIS-856 Test fixes #2209
Conversation
|
@michaelandrepearce I need you to take a look into this please. MessageRedistributionFix is broken, up to the point I can't complete a whole testsuite on my internal CI. My idea was the emulate the previous collection where redistributor would be an item, while still checking if redistributor is the only allowed item to be used on the loop. I'm not sure how else we would change this without making substantial refactoring to your previous commit. Can you look into this PR please? |
|
@michaelandrepearce : But please don't merge it yet.. I'm running a whole testsuite on the CI before we can merge this... just let me know what you think first. |
clebertsuconic
force-pushed
the
redistribution-fix
branch
from
ab25403
to
0b4c6e4
Compare
|
<<<< I had written here, asking Michael to take a look on ExclusiveTest, but I later figured it out.. so I removed the comment here .. :) >>>> |
clebertsuconic
force-pushed
the
redistribution-fix
branch
from
26b5d06
to
e75965f
Compare
clebertsuconic
changed the title
|
@clebertsuconic, looks good, theres one bit of debug code youve left in that needs to be removed., there we some bits with consumer lists with the redistributor i heavily want to avoid, im working an alternative option, but if to fix master happy to merge this once the debug code is removed, and i can supply my alternative later (have raised a pr so you can see, but still not complete) |
| @@ -544,6 +560,7 @@ public boolean isExclusive() { | |||
|
|
|||
| @Override | |||
| public synchronized void setExclusive(boolean exclusive) { | |||
| new Exception("exclusive set at " + exclusive).printStackTrace(); | |||
There was a problem hiding this comment.
Think this needs to be removed.
There was a problem hiding this comment.
Thanks. That’s debug I forgot :p
|
This is replaced by #2211 |
No description provided.