ARTEMIS-2029 Fixing wire checks after reconnects #2247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
commented
Aug 13, 2018
| @@ -638,13 +638,9 @@ public synchronized CoreMessage encode() { | |||
|
|
|||
| checkProperties(); | |||
|
|
|||
| if (writableBuffer != null) { | |||
There was a problem hiding this comment.
ouch.. don't merge this.. didn't mean this change!!!!
clebertsuconic
force-pushed
the
compat
branch
2 times, most recently
from
282a602
to
75b01dd
Compare
|
It's good now.. I found a change I added by mistake |
|
Looks like compatibility tests are failing. |
|
Yeah. I will fix it later today. |
|
It’s a simple fix. I will have to adjust counts. As for everything else. Do u think this is ok ? |
|
Seems OK. I would have thought that the channelVersion would get set when the session was re-created on the backup (e.g. in |
|
@jbertram it's not.. there's a different packet on reconnect sessions. So that's not called. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.