ARTEMIS-2023 Avoiding boolean on every message for 1x and tests #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
force-pushed
the
compatible-changes
branch
3 times, most recently
from
9eee8c1
to
02c1ed8
Compare
|
Can we remove the need for core session to know about a jms 1x fix with this? Or is that already gone in the last change you did. I cant remember |
|
@michaelandrepearce it's not there any longer. it's just Session. Just using extension instead of boolean. that's all. |
|
For some reason compatibility-tests are broken. I didn't break compatibility tests.. but there's something I need to fix. I planning this to be the last PR before releasing. (and cherry-pick) |
clebertsuconic
force-pushed
the
compatible-changes
branch
from
02c1ed8
to
93cffed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.