Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-2074 URI not transposing ServerLocator on ConnectionFactory #2292

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ public class ActiveMQConnectionFactory extends JNDIStorable implements Connectio

private static final long serialVersionUID = 6730844785641767519L;

public ServerLocator setUseTopologyForLoadBalancing(boolean useTopologyForLoadBalancing) {
return serverLocator.setUseTopologyForLoadBalancing(useTopologyForLoadBalancing);
}

public boolean getUseTopologyForLoadBalancing() {
return serverLocator.getUseTopologyForLoadBalancing();
}

private ServerLocator serverLocator;

private String clientID;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,13 @@ protected JMSConnectionOptions newConectionOptions(URI uri, Map<String, String>
return BeanSupport.setData(uri, new JMSConnectionOptions(), query);
}


protected ActiveMQConnectionFactory setData(URI uri,
Map<String, String> query,
ActiveMQConnectionFactory factory) throws Exception {
BeanSupport.setData(uri, factory.getServerLocator(), query);
return BeanSupport.setData(uri, factory, query);
}


}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ protected ActiveMQConnectionFactory internalNewObject(URI uri,
String name) throws Exception {
JMSConnectionOptions options = newConectionOptions(uri, query);
ActiveMQConnectionFactory factory = ActiveMQJMSClient.createConnectionFactoryWithoutHA(options.getFactoryTypeEnum(), InVMTransportConfigurationSchema.createTransportConfiguration(uri, query, name, "org.apache.activemq.artemis.core.remoting.impl.invm.InVMConnectorFactory"));
return BeanSupport.setData(uri, factory, query);
BeanSupport.setData(uri, factory, query);
BeanSupport.setData(uri, factory.getServerLocator(), query);
return factory;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public ActiveMQConnectionFactory internalNewObject(URI uri,
} else {
factory = ActiveMQJMSClient.createConnectionFactoryWithoutHA(dcConfig, options.getFactoryTypeEnum());
}
return BeanSupport.setData(uri, factory, query);
return setData(uri, query, factory);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ protected ActiveMQConnectionFactory internalNewObject(URI uri,
factory = ActiveMQJMSClient.createConnectionFactoryWithoutHA(options.getFactoryTypeEnum(), tcs);
}

return BeanSupport.setData(uri, factory, query);
return setData(uri, query, factory);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public ActiveMQConnectionFactory internalNewObject(URI uri,
} else {
factory = ActiveMQJMSClient.createConnectionFactoryWithoutHA(dgc, options.getFactoryTypeEnum());
}
return BeanSupport.setData(uri, factory, query);
return setData(uri, query, factory);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -719,4 +719,15 @@ public void test1xNamingNegative() throws NamingException, JMSException {

connection.close();
}

@Test
public void testUseTopologyForLoadBalancing() throws Exception {
Hashtable<String, String> props = new Hashtable<>();
props.put(Context.INITIAL_CONTEXT_FACTORY, "org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory");
props.put("connectionFactory.ConnectionFactory", "vm://0?useTopologyForLoadBalancing=false");
Context ctx = new InitialContext(props);

ConnectionFactory connectionFactory = (ConnectionFactory) ctx.lookup("ConnectionFactory");
assertFalse(((ActiveMQConnectionFactory)connectionFactory).getServerLocator().getUseTopologyForLoadBalancing());
}
}