ARTEMIS-2285 Sorting by user column in connections view not working #2592
Conversation
|
looking good. Could you add a unit test? |
| for (ServerSession session : sessions) { | ||
| String username = session.getUsername() == null ? "" : session.getUsername(); | ||
| users.add(username); | ||
| } | ||
| return users; | ||
| return StringUtil.joinStringList(users, ","); |
There was a problem hiding this comment.
Whilst i understand change from HashSet to TreeSet to give ordering, the return shouldn't change the type, e.g just return users still. Or im missing something.... i guess a test may help to describe/show why its needed.
There was a problem hiding this comment.
The returned value is a set of users of a single connection. to sort the connections by their user(s), these lists need to be comparable with each other. however treeset does not implement the comparable interface, so you cannot sort multiple treesets by there values. thus the PR now returns a comparable/sortable string representation of the set. does that make sense?
|
I will try to provide a test case. stay tuned :) |
|
@gaohoward @michaelandrepearce I added a test as requested. |
|
@sebthom thanks for this great contributions. merged. |
The value returned by ConnectionsView.getField(con, "users") currently returns a Set which does not implement the Comparable interface thus ActiveMQAbstractView#getComparator() always returns a comparator which evaluates to 0.