ARTEMIS-2358 - Add user and pass to database store to allow encryption #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
reviewed
May 29, 2019
docs/user-manual/en/security.md
Outdated
| @@ -19,6 +19,12 @@ certificate this name is the name to which their certificate's DN maps. If | |||
| server will simply use whatever user name (if any) the client provides. This | |||
| option is `false` by default. | |||
|
|
|||
| ## Rejecting messages without a Validated user | |||
There was a problem hiding this comment.
This doesn't seem related to this PR
franz1981
reviewed
May 29, 2019
| @@ -73,7 +73,7 @@ This approach might be preferred if for example you only have access to the 5.x | |||
| ```xml | |||
| <bean id="5xConnectionFactory" class="org.apache.activemq.ActiveMQConnectionFactory"> | |||
| <property name="brokerURL" value="tcp://localhost:61616"/> | |||
| <property name="userName" value="admin"/> | |||
| <property name="user" value="admin"/> | |||
There was a problem hiding this comment.
This doesn't seem related to this PR (as above)
franz1981
reviewed
May 29, 2019
| @@ -25,7 +25,7 @@ | |||
| <broker brokerName="receiver" persistent="false" useJmx="true" allowTempAutoCreationOnSend="true" xmlns="http://activemq.apache.org/schema/core"> | |||
|
|
|||
| <networkConnectors> | |||
| <networkConnector uri="static:(tcp://localhost:62001)" userName="system" password="manager"/> | |||
| <networkConnector uri="static:(tcp://localhost:62001)" user="system" password="manager"/> | |||
There was a problem hiding this comment.
This doesn't seem related to this PR
franz1981
suggested changes
May 29, 2019
| @@ -25,7 +25,7 @@ | |||
| <broker brokerName="sender" persistent="false" useJmx="true" xmlns="http://activemq.apache.org/schema/core"> | |||
|
|
|||
| <networkConnectors> | |||
| <networkConnector uri="static:(tcp://localhost:62002)" userName="system" password="manager"> | |||
| <networkConnector uri="static:(tcp://localhost:62002)" user="system" password="manager"> | |||
There was a problem hiding this comment.
This doesn't seem related to this PR
|
Ive merged some changes from @franz1981 to deal with comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARTEMIS-2358