ARTEMIS-2366 artemis-service start fails #2733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ | |||
| <logmode>roll</logmode> | |||
|
|
|||
| <executable>%JAVA_HOME%\bin\java.exe</executable> | |||
| <startargument>-Xbootclasspath/a:%ARTEMIS_HOME%\lib\${logmanager}</startargument> | |||
| <startargument>-Xbootclasspath/a:%ARTEMIS_HOME%\lib\${logmanager};%ARTEMIS_HOME%\lib\${wildfly-common}</startargument> | |||
There was a problem hiding this comment.
Have we an updated version yet of jar dep yet? Before we make further changes to support it. Incase it doesnt come and we have to revert the other pr that added it.
There was a problem hiding this comment.
I don't understand what you're asking.
There was a problem hiding this comment.
Have we updated wildfly common yet
There was a problem hiding this comment.
@michaelandrepearce even thought there's no real issue in there, the PR is being merged and a new release is being made soon, out of caution.
There was a problem hiding this comment.
FWIW, I just pushed a commit to move Wildfly Common to 1.5.2.Final. That should address the license question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.