CANCELLED ARTEMIS-2412: Allow CF configuration through JNDI references #2746
Conversation
|
FYI I think there's something wrong with the Travis-CI. I ran a 'mvn clean install' on my dev PC (well, IntelliJ equivalent), without encountering any errors. Also, the Travis-CI build seems to fail in a place I have not touched. |
|
I ran the PR build on my local machine and it passed. This PR looks good, but I hesitate to merge it without any kind of test. Perhaps add a test to |
|
Test case added. Let me know if this is good enough... |
|
I'm sorry, but I can't merge this with a merge commit on your branch. Your add test is a merge commit. Please, keep your branch flat. it's impossible to work with merge commits on any PR on any project I know out there. do the following at least: Other things missing: a JIRA: and a JIRA comment on your commit you should have a single commit on your PR. Let me know if you need any help with git-fu on cleaning up your PR. I'm usually good on cleaning up myself with intermediate branches, but your case here was a bit difficult for me. It should be easier on your end since you know your changes. thanks! |
properties into brokerURL if they have been set on ActiveMQConnectionFactory
Most connection related properties, like the SSL ones, currently have to be encoded in the brokerURL. When configuring connections purely through JNDI bindings, this is not always desireable. This commit allows one to configure all properties included in TransportConstants.ALLOWABLE_CONNECTOR_KEYS to be listed separately in the JNDI bindings. These properties are then zipped into any provided brokerURL. For properties that appear in both places, the one specified separately in the JNDI bindings takes priority. This commit should not affect any configuration other than those configure through JNDIReferenceFactory.
boekhold
changed the title
|
Closing this one, will submit a new PR with a single commit referencing JIRA |
Most connection related properties, like the SSL ones, currently
have to be encoded in the brokerURL. When configuring connections
purely through JNDI bindings, this is not always desireable.
This commit allows one to configure all properties included
in TransportConstants.ALLOWABLE_CONNECTOR_KEYS to be listed separately
in the JNDI bindings. These properties are then zipped into any
provided brokerURL. For properties that appear in both places,
the one specified separately in the JNDI bindings takes priority.
This commit should not affect any configuration other than those
configure through JNDIReferenceFactory.