Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-2425 Message loss due to writing incomplete page file #2748

Merged
merged 1 commit into from Jul 15, 2019

Conversation

wy96f
Copy link
Contributor

@wy96f wy96f commented Jul 12, 2019

The last page file might be incomplete if broker crashes or the disk is damaged. After broker is up, we keep writing this incomplete page file. If the cache of the file is evicted, we read this file to deliver messages which we would lose messages written after broker up.

Copy link
Contributor

@franz1981 franz1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'm on the phone now: need to run this on CI to be sure

@asfgit asfgit merged commit fa46647 into apache:master Jul 15, 2019
asfgit pushed a commit that referenced this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants