[ARTEMIS-2626]: Postgresql Journal implementation requires the jdbc driver to be in the same classloader #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehsavoie sort of a nit-pic but the only thing wrong here is the title for the commit the bug is Postgres JDBC requires JDBC driver.. The fix is... allowing Postgres to use the driver in a certain way... etc.. Can you be a bit more descriptive of the fix itself instead of using the bug description? |
|
It's just that when I look for a list of commits, I like to understand what was changed.. to follow cherry-picks.. etc.. |
…ess to PostgeSQL driver internal classes. Issue: The BLOB manipulation is done using PostgreSQL internal classes starting from PGConnection. This leads to ClasCastExceptions if the connection is wrapped in a pool or if the driver is in a different classloader (WildFly). Fix: unwrap the connection and if the PostgreSQL classes are not directly available uses reflection to manipulate the BLOBs. Jira: https://issues.apache.org/jira/browse/ARTEMIS-2626
ehsavoie
force-pushed
the
ARTEMIS-2626
branch
from
8ab15e5
to
ac98cda
Compare
|
Is this better ? |
|
Nice !!! I thought about something simple. You went beyond complete now. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The BLOB manipulation is done using PostgreSQL internal classes starting from PGConnection. This leads to ClasCastExceptions if the connection is wrapped in a pool or if the driver is in a different classloader (WildFly).
Fix:
unwrap the connection and if the PostgreSQL classes are not directly available uses reflection to manipulate the BLOBs.
Jira: https://issues.apache.org/jira/browse/ARTEMIS-2626
Supersedes #2948