ARTEMIS-2701 Improving DLQ/check over previously removed records #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added two operations to the journal... and used them on DLQ / Rollback if something previously removed the message during the DLQ check.. we will just ignore the operation normally. |
|
@michaelandrepearce can you review this one? |
clebertsuconic
force-pushed
the
journal-fix
branch
from
01f82f9
to
af796d5
Compare
| if (!dest.isTemporary()) { | ||
| // this should not really happen, | ||
| // so I'm not creating a Logger for this | ||
| logger.warn("OpenWire client sending a queue remove towards " + dest.getPhysicalName()); |
There was a problem hiding this comment.
I dont get this change, why shouldnt this happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.