ARTEMIS-2987 improve message body display #3350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <h2>Headers</h2> | ||
| <h4>Message ID: {{$ctrl.currentMessage.messageID}}</h4> | ||
|
|
||
| <h4>Displaying body as <span ng-bind="$ctrl.currentMessage.textMode"></span></h4> |
There was a problem hiding this comment.
did you test this on both AMQP and Core?
There was a problem hiding this comment.
I did a quick test for this with core, but this change is really just superficial. There's no semantic change here. The same information is being displayed as always, just in a slightly different way.
There was a problem hiding this comment.
I see. I haven't fully read the whole PR at the time I posted this.. I thought you implemented some visutalzation of the body, in which case you would have needed to change some java code..
it's fine then.. thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.