ARTEMIS-3106 Fixing javadoc build for artemis-amqp-protocol #3543
Conversation
|
@gemmellr you reverted this commit (that I am reapplying on this PR). the dependency was added to fix the javadoc build, as the dependency to Artemis-server between AMQP and server was indirect. Not having the dependency here will break javadoc build. if we cannot have the dependency, we would need another approach to fix javadoc here. |
|
Thats odd. The dependency is already there. Maven even complains about it being duplicated and threatens it may break the build in future. |
|
It is odd actually... perhaps it's an ordering thing for javadoc build...? I guess I could remove the last one, and keep the first. |
|
I guess its an ordering issue. The dependency was already there and is still there at: activemq-artemis/artemis-protocols/artemis-amqp-protocol/pom.xml Lines 85 to 89 in 3c90c69 Perhaps moving it up to where the one removed is would be the actual change. Though I have no idea why that should matter, I'd guess something else is arguably broken for that to matter. |
|
Cross post :) |
|
let me double check with and without the option.. to make sure I'm not screwing up things |
|
Actually, the build passed with my commit...are you sure its broken? https://github.com/apache/activemq-artemis/actions/runs/748202508 |
|
not any more! :) |
|
let me double check.. sorry for the hassle |
|
@gemmellr can you pretend you never saw this PR? I don't know what happened... sorry about that... |
|
Hehe sure I can do that :) |
You should better make ASF Github / Jira bot more silent then as it sends out a mail for every comment here :-D |
The reference between AMQP Protocol and Server was Indirect.
Not having the dependency explictly set ill break Javadoc.
I am reapplying the commit reverted to fix the javadoc build.
Revert "ARTEMIS-3106: remove duplicate artemis-server dependency added in 5313a80"
This reverts commit 3c90c69.