ARTEMIS-3271 Improve Critical Analyzer to sample single therads #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
changed the title
clebertsuconic
force-pushed
the
thread-check
branch
11 times, most recently
from
c0e3b70
to
0282e9c
Compare
worked in collaboration with Gary Tully on this fix
clebertsuconic
force-pushed
the
thread-check
branch
from
0282e9c
to
8ab51e1
Compare
|
looks good. the test captures the failure nicely. I guess the sampling is not unlike the current behaviour where multiple threads can modify the state. At least now there won't be any false positives. |
|
Thinking out loud, if we want to improve on sampling, and check every thread enter/exit, some sort of xor of the thread id and the analyser doing mark (to capture the current bit mask) and sweep if it has not changed since the mark, could work without recourse to tracking nanno time. Something for the future maybe. |
|
I don't think we need to check on every thread. I was just checking around, and most uses are OK for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.