ARTEMIS-3309 Add a parameter to limit messages to move or transfer #3590
Conversation
brusdev
force-pushed
the
limit_move_messages
branch
3 times, most recently
from
8feab58
to
8002182
Compare
| @@ -105,10 +105,207 @@ | |||
| @Option(name = "--target-topic", description = "Destination to be used. It can be prefixed with queue:// or topic:// and can be an FQQN in the form of <address>::<queue>. (Default: queue://TEST)") | |||
| String targetTopic; | |||
|
|
|||
| boolean isCopy() { | |||
| @Option(name = "--max-count", description = "The maximum number of messages to transfer.") | |||
There was a problem hiding this comment.
Can we make this consistent to ./artemis consumer... so this would come as --message-count ?
Can you check others...
if you want to expand towards those options.. isn't this something you could share a common base class with consumer?
There was a problem hiding this comment.
The max-count parameter has a different name from message-count because it has a different semantic. The first one defines the maximum number of messages to transfer while the second one would define the exact number of messages to transfer waiting if the available messages are less than the message-count value (as the consumer does).
There was a problem hiding this comment.
Seems pretty much the same to me.
./artemis consumer --message-count means.. the name of messages to consume...
While
./artemis transfer --message-count would mean the maximum number of messages to transfer.
it would keep CLI clean. things would get easier to remember when you move from one tool to another.
There was a problem hiding this comment.
I see, I have just pushed a commit to fix the parameter name.
brusdev
force-pushed
the
limit_move_messages
branch
from
8002182
to
ad7f87e
Compare
No description provided.