ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264 #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtully can you take a look |
gtully
approved these changes
Oct 6, 2021
|
Great. I'll leave it open for further opinions on when it should go in. @jbertram @clebertsuconic |
|
@gemmellr I can't say no to removing code :). LGTM |
|
I was tempted to hit Rebase and merge already.. I will let you do it in case you want more reviews. |
Follows earlier test removal in a3de3d4
|
It was mostly opinion on the timing I was looking for, so if you were inclined just to merge it then I will do so now. |
gemmellr
force-pushed
the
unwind-krb5-ssl-ARTEMIS-1264
branch
from
b85118f
to
a5b5a50
Compare
|
I think it's good timing already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unwinds the effects of the RFC 2712 'Kerberos SSL ciphers' support added in ARTEMIS-1264. The functionality was recommended against use even then, and was removed entirely from JDK11. It has been disabled by default in JDK8 for a while. OpenSSL removed its equivalent support in 2015. It is no longer being tested, with the tests already removed (a3de3d4) since no modern JVMs can do it out of the box.
The code has changed and moved around a lot since as the surrounding areas were updated, other functionality added etc, so this was a case of making the related unwinds rather than reverting what was added as such. The docs included a note of the support, including mention it is insecure, though the specific steps needed to configure and use it were seemingly never added.
Once #3696 lands this functionality becomes 100% defunct, but its largely already unusable and shouldn't really be used anyway so I don't think this PR needs to wait for that one.