ARTEMIS-3556 show message protocol on message view page #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...src/main/java/org/apache/activemq/artemis/core/message/openmbean/MessageOpenTypeFactory.java
Outdated
Show resolved
Hide resolved
michaelandrepearce
requested changes
Nov 6, 2021
erwindon
changed the title
| @@ -123,6 +124,7 @@ protected void init() throws OpenDataException { | |||
| public Map<String, Object> getFields(M m, int valueSizeLimit, int deliveryCount) throws OpenDataException { | |||
| Map<String, Object> rc = new HashMap<>(); | |||
| rc.put(CompositeDataConstants.MESSAGE_ID, "" + m.getMessageID()); | |||
| rc.put(CompositeDataConstants.PROTOCOL, m.getClass().getSimpleName()); | |||
There was a problem hiding this comment.
we could add a method on Message to return a more user friendly word?
on Message:
public String getProtocol();
then on core you return "CORE" and AMQP you return "AMQP"
?
There was a problem hiding this comment.
I already made that change exactly as you and Michael suggest. that code is in the next commit.
There was a problem hiding this comment.
maybe I should squash to prevent confusion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/ARTEMIS-3556