ARTEMIS-3576 Fix toString methods throwing exceptions #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its nice to see the runtime has been reduced from ~30 seconds to 'only' ~5 seconds in this version of the PR. Thats still a significant chunk of time I dont think this is worth spending on each build for this, the classes changed should have specific tests of their behaviour taking milliseconds rather than relying on something like this, however it is at least less egregious with the further 25 seconds knocked off. If we are going to have this it could at least produce the cleanest output possible to begin with though. Currently the output is still showing stacktraces for a couple of silly cases:
|
gemmellr
reviewed
Dec 2, 2021
...ent/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
Outdated
Show resolved
Hide resolved
| @@ -238,6 +238,8 @@ public ClientSessionFactoryImpl(final ServerLocatorInternal serverLocator, | |||
| if (connectorConfig.getB() != null) { | |||
| this.backupConnectorConfig = connectorConfig.getB(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@brusdev I will send a PR removing this right now :)
that way you rebase without this...
...ent/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.