ARTEMIS-3711 support AMQ_SCHEDULED_DELAY for OpenWire clients #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-3711
branch
7 times, most recently
from
2e1a373
to
d4b382b
Compare
gemmellr
reviewed
Mar 11, 2022
...c/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/activemq/artemis/tests/integration/openwire/OpenWireScheduledDelayTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+228
to
+234
| final Object scheduledDelay = messageSend.getProperties().get(ScheduledMessage.AMQ_SCHEDULED_DELAY); | ||
| if (scheduledDelay instanceof Long) { | ||
| coreMessage.putLongProperty(org.apache.activemq.artemis.api.core.Message.HDR_SCHEDULED_DELIVERY_TIME, System.currentTimeMillis() + ((Long) scheduledDelay)); | ||
| // this property may have already been copied, but we don't need it anymore | ||
| coreMessage.removeProperty(ScheduledMessage.AMQ_SCHEDULED_DELAY); | ||
| } | ||
|
|
There was a problem hiding this comment.
final Object scheduledDelay = messageSend.getProperties().get(ScheduledMessage.AMQ_SCHEDULED_DELAY);
if (scheduledDelay instanceof Number) {
coreMessage.putLongProperty(org.apache.activemq.artemis.api.core.Message.HDR_SCHEDULED_DELIVERY_TIME, System.currentTimeMillis() + ((Number) scheduledDelay).longValue());
// this property may have already been copied, but we don't need it anymore
coreMessage.removeProperty(ScheduledMessage.AMQ_SCHEDULED_DELAY);
}
There was a problem hiding this comment.
Are you sure about restricting it as long?
What about using Number, and longValue() ?
There was a problem hiding this comment.
I just checked and the openwire client has a check.. so it's ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.