ARTEMIS-3761 Improve page cleanup to remove messages in the middle of the stream #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
force-pushed
the
page_cleaner
branch
2 times, most recently
from
baf8ea5
to
a6b91c7
Compare
|
I'm adding more tests... but I don't plan to make any changes to the code... feel free to review it. |
clebertsuconic
force-pushed
the
page_cleaner
branch
4 times, most recently
from
0349245
to
99b4b17
Compare
clebertsuconic
force-pushed
the
page_cleaner
branch
5 times, most recently
from
988d885
to
a51f0b3
Compare
|
converting to draft as there's a test failing |
clebertsuconic
force-pushed
the
page_cleaner
branch
from
a51f0b3
to
33c5534
Compare
clebertsuconic
commented
Apr 7, 2022
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
Outdated
Show resolved
Hide resolved
this test was relying on internal details such as number of credits on the link. The test was flaky and eventually failing or hunging.
clebertsuconic
force-pushed
the
page_cleaner
branch
3 times, most recently
from
93b2dd2
to
54fce9b
Compare
…ception from the Iteration QueueImpl::browserIterator could throw NoSuchElementException and this is fixing the iterator Found this while testing ARTEMIS-3761
… the stream as well Paging only removes files at the beginning of the stream... Say you have paged files 1 through 1000... if all the messages are ack, but one message on file 1 is missing an ack, all the 999 subsequent files would not be removed until all the messages on file 1 is ack. This was working as engineered, but sometimes devs don't have complete control on their app. With this improvement we will now remove messages in the middle of the stream as well. There is also some improvement to how browsing and page work with this
clebertsuconic
force-pushed
the
page_cleaner
branch
from
54fce9b
to
4b4aec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.