ARTEMIS-3848 High CPU usage on ReadWriteLocks #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
suggested changes
May 25, 2022
franz1981
reviewed
May 25, 2022
...org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
thread-local
branch
2 times, most recently
from
3cdd7a6
to
80dd821
Compare
|
@franz1981 it might be an option: however I don't want to break anything else now. I may do that as a major separate task. |
clebertsuconic
commented
May 25, 2022
| localListenersPool.set(null); | ||
|
|
||
| // We are reusing a previously created ArrayList for this localArray | ||
| ArrayList<ReadyListener> localArrayList = readyListenersPool.get(); |
There was a problem hiding this comment.
@franz1981 I'm changing this code you wrote here. This was also introducing many entires on the ThreadLocal.
clebertsuconic
commented
May 25, 2022
...ient/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
Outdated
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
thread-local
branch
3 times, most recently
from
0050b0b
to
20d2014
Compare
gemmellr
reviewed
May 25, 2022
...ient/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
Outdated
Show resolved
Hide resolved
...org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
Show resolved
Hide resolved
...c/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageManager.java
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
thread-local
branch
from
20d2014
to
9b1c63e
Compare
JMSTestCase is deprecated anyway. in its older form many many years ago a server would be reused over between tests. what forced us to make such verification to avoid messages from one test leaking into the next. This was because a server startup was expensive many years ago (less efficient code and the hardware available 10 years ago) with the current state of things this is not needed as the server will be started from scratch on every test
clebertsuconic
force-pushed
the
thread-local
branch
from
9b1c63e
to
8782ca2
Compare
This is caused by too many entries on the HashMap for ThreadLocals. Also: I'm reviewing some readlock usage on the StorageManager to simplify things a little bit.
clebertsuconic
force-pushed
the
thread-local
branch
from
8782ca2
to
b3c1f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by too many entires on the HashMap for ThreadLocals.
Also: I'm reviewing some readlock usage on the StorageManager to simplify things a little bit.