JBEAP-3173 Synchronization performed on java.util.concurrent.ConcurrentLinkedDeque object in class NettyConnection

[kurobako]

JBEAP-3173 Synchronization performed on java.util.concurrent.ConcurrentLinkedDeque object in class NettyConnection

• synchronized keywords are now placed on methods since there are only two such methods in the class and both use the same monitor
• LinkedList is used as a stack holding ReadyListeners instead of blocking data structure since all access to it is serialized anyway and there is no reason to have additional memory barriers.

[kurobako]

from Jenkins log:

[INFO] There is 1 error reported by Checkstyle 6.2 with /x1/jenkins/jenkins-slave/workspace/ActiveMQ-Artemis-PR-Build/artemis-core-client/../etc/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java27:8 UnusedImports: Unused import - java.util.concurrent.CountDownLatch.

please note my changes are in NettyConnection.java and have nothing to do with reported error

[clebertsuconic]

JBEAP is not an apache JIRA. It belongs to your internal system. Can you ammend the commit and remove such JIRA comment please? Perhaps you should create an apache JIRA.

Although I'm not sure about your commit, you are using the synchronized on the NettyConnection while I wanted to leave it alone. I will probably amend your commit before merging anyways.