ARTEMIS-3963 Fix setting security roles via properties on OpenJ9 JDK 11 #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoleSet.class.getMethods() returns the same methods on both OpenJDK 11 and OpenJ9 JDK 11 but the order is different. OpenJDK 11 returns `public void org.apache.activemq.artemis.core.config.impl.RoleSet.add` before `public boolean java.util.HashSet.add` while OpenJ9 JDK 11 returns `public boolean java.util.HashSet.add` before `public void org.apache.activemq.artemis.core.config.impl.RoleSet.add`
gtully
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoleSet.class.getMethods() returns the same methods on both OpenJDK 11 and
OpenJ9 JDK 11 but the order is different. OpenJDK 11 returns
public void org.apache.activemq.artemis.core.config.impl.RoleSet.addbeforepublic boolean java.util.HashSet.addwhile OpenJ9 JDK 11 returnspublic boolean java.util.HashSet.addbeforepublic void org.apache.activemq.artemis.core.config.impl.RoleSet.add