Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTEMIS-4035 all consumers of federated queue drop if only one consum… #4249

Closed
wants to merge 1 commit into from
Closed

ARTEMIS-4035 all consumers of federated queue drop if only one consum… #4249

wants to merge 1 commit into from

Conversation

jbertram
Copy link
Contributor

…er drops

gtully
gtully approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@gtully gtully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test and fix!

@clebertsuconic
Copy link
Contributor

@jbertram LGTM: if you could check the whole test suite before merging it though?

@asfgit asfgit closed this in a7bbe3c Oct 13, 2022
@jbertram
Copy link
Contributor Author

@clebertsuconic, I just saw your comment after I merged. I'm running the full test-suite now. FWIW, I ran all the federations tests manually and they all passed.

@jbertram
Copy link
Contributor Author

Full test-suite looks good. No related failures.

@jbertram jbertram deleted the ARTEMIS-4035 branch September 13, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtully gtully gtully approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jbertram @clebertsuconic @gtully