Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-4042 - remove use of codec system property from scripts as en… #4306

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

gtully
Copy link
Contributor

@gtully gtully commented Dec 6, 2022

…v var can now be read directly

@gtully
Copy link
Contributor Author

gtully commented Dec 6, 2022

@gemmellr has this any implications for the new upgrade scripts that I am missing? Functionally there is no behaviour change so I think not.

@gemmellr
Copy link
Member

gemmellr commented Dec 6, 2022

This should have its own JIRA for tracking the change, not reusing an existing already released one; the earlier change on the 4042 JIRA has been in 2 previous releases already.

@gemmellr
Copy link
Member

gemmellr commented Dec 6, 2022

@gemmellr has this any implications for the new upgrade scripts that I am missing? Functionally there is no behaviour change so I think not.

I dont believe so, it should just 'remove' this as desired, if present in the old file, by virtue of it no longer being in the current file. Easy enough to check the output of an upgrade (or look at the tests) to confirm though.

@gtully gtully merged commit bfb33c7 into apache:main Dec 8, 2022
@gtully
Copy link
Contributor Author

gtully commented Dec 8, 2022

new jira https://issues.apache.org/jira/browse/ARTEMIS-4112 - thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants