ARTEMIS-4132 AMQP Receiver default to ANYCAST when creating an address #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmellr
reviewed
Jan 23, 2023
There was a problem hiding this comment.
Though I'd really prefer things actually defaulted to anycast as this effectively does for receivers, the described 'different autocreate behaviour if creating sender first' is clearly broken, and the expectation was the address/routing config controls it so making it use that does seem correct.
...rg/apache/activemq/artemis/tests/integration/amqp/AutoCreateWithDefaultRoutingTypesTest.java
Outdated
Show resolved
Hide resolved
...rg/apache/activemq/artemis/tests/integration/amqp/AutoCreateWithDefaultRoutingTypesTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java
Outdated
Show resolved
Hide resolved
tabish121
force-pushed
the
ARTEMIS-4132
branch
2 times, most recently
from
7007042
to
362c01e
Compare
When an AMQP client subscribes to a new address (non-existing) with a receiver link, the address is created with routing type ANYCAST regardles of the default address creation configuration of the broker, and ignores even the broker wide default of MULTICAST.
tabish121
force-pushed
the
ARTEMIS-4132
branch
from
362c01e
to
ca66028
Compare
|
LGTM...started a full test run on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AMQP client subscribes to a new address (non-existing) with a receiver link, the address is created with routing type ANYCAST regardles of the default address creation configuration of the broker, and ignores even the broker wide default of MULTICAST.