ARTEMIS-4267 original exception lost for NoCacheLoginException #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusdev
reviewed
May 3, 2023
...src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java
Outdated
Show resolved
Hide resolved
jbertram
force-pushed
the
ARTEMIS-4267
branch
3 times, most recently
from
e36fc8d
to
5de99b8
Compare
brusdev
reviewed
May 4, 2023
...server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/LDAPLoginModule.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java
Outdated
Show resolved
Hide resolved
When skipping the authentication cache details for the original exception are not logged. This commit ensures these details are logged and adopts the ExceptionUtils class from Apache Commons Lang in lieu of the previous custom implementation.
brusdev
approved these changes
May 8, 2023
|
Looks good, I just need to take a look at the tests themselves more closely, I will do so probably tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When skipping the authentication cache the original exception is not logged.
This commit ensures the original exception is logged and adopts the ExceptionUtils class from Apache Commons Lang in lieu of the previous custom implementation.