ARTEMIS-4424 Unecessary AMQ212025 (not connected) when no nodes are c… #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
force-pushed
the
ARTEMIS-4424
branch
2 times, most recently
from
0bd5f82
to
a237939
Compare
|
this PR contains a trivial fix. I will merge it as soon as I have some tests done. |
|
It currently also contains the JDBC fix with it.. which will be removed of course before merging. (I'm keeping both commits here now just for testing). |
…onnected The exception thrown by serverLocator.connect() should be all you need on such case and the caller should then be responsible for taking appropriate action.
clebertsuconic
force-pushed
the
ARTEMIS-4424
branch
from
a237939
to
f1d8f16
Compare
|
I'm done with tests.. just waiting CI from the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onnected
The exception thrown by serverLocator.connect() should be all you need on such case and the caller should then be responsible for taking appropriate action.