ARTEMIS-4576 ServerSessionImpl#updateProducerMetrics access large messages after being routed #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmellr
reviewed
Jan 18, 2024
...mis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
Outdated
Show resolved
Hide resolved
gaohoward
force-pushed
the
lm_access_after_route
branch
from
8b1ccd1
to
561f19b
Compare
gemmellr
reviewed
Jan 18, 2024
...mis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
Outdated
Show resolved
Hide resolved
…sages after being routed
gaohoward
force-pushed
the
lm_access_after_route
branch
from
561f19b
to
e51ab97
Compare
gemmellr
reviewed
Jan 19, 2024
| @@ -2520,10 +2524,10 @@ public String toManagementString() { | |||
| return "ServerSession [id=" + getConnectionID() + ":" + getName() + "]"; | |||
| } | |||
|
|
|||
| private void updateProducerMetrics(Message msg, String senderName) { | |||
| private void updateProducerMetrics(Message msg, String senderName, int lmSize) { | |||
There was a problem hiding this comment.
lmSize still needs updated here
|
Once the variable is renamed I think this looks good. Though I think someone more familiar with the routing and large message stuff should also give it a once over. @clebertsuconic @jbertram |
|
@howardgao I don't actually understand what's being fixed.. it seems the same semantic.. replacing 6 by half dozen? Perhaps you meant to check this for AMQP, in which case you would have to also check for AMQPLargeServerMessage... or maybe add another method to an upper level? if you actually create a test to validate what's wrong, it would be check the right fix. |
|
Ohhh.. I see now... |
|
I pushed this directly... hence I'm closing this PR as I already "merged it" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerSessionImpl#updateProducerMetrics method is being called after a message is routed. If the message is a large message, it can be acked quickly and it's backing file will be closed before the method is being called.
This bug causes random failure in test org.apache.activemq.artemis.tests.integration.paging.MessagesExpiredPagingTest#testSendReceiveCORELarge